I will echo what JH has said as far as having the right environments for rogues to excel in. Often times when people repeat sweeping generalizations about a class, the assumptions don't really line up with actual play (hence white room optimization).

For me, whenever it comes time to make a character and select a class... I can't really ever get over the fact that their second subclass feature comes online at level nine. Other classes are 1 level away from their THIRD feature, as opposed to just getting their second feature. It's just way too late in the lifespan of a campaign (generally).

That said, a dedicated skill monkey with Expertise, subclass skill features, bonus action mobility, and eventually Reliable Talent would be great in a party. In our current party, it's a crap shoot who will attempt what skill check, because we all have poor modifiers to most of them.